fix(desktop): handle packaged debug shortcut via before-input-event#939
Merged
fix(desktop): handle packaged debug shortcut via before-input-event#939
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mrcfps
approved these changes
Apr 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Handle the packaged Develop-mode toggle inside
before-input-eventsoCmd/Ctrl+Shift+Alt+Dworks even when the global shortcut registration is unavailable.Why
On Windows, other software can block the app-level global shortcut registration, which leaves packaged builds stuck without a working way to reveal the Develop menu for debugging.
How
Add a fallback handler in the packaged
before-input-eventpath that togglesproductionDebugModeand refreshes the application menu before the reload-shortcut guard runs.Affected areas
Checklist
pnpm typecheckpasses (blocked in this worktree: dependencies / local tools missing,tscnot found)pnpm lintpasses (blocked in this worktree:biomenot found)pnpm testpasses (blocked in this worktree:vitestnot found)pnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
Manual verification target: packaged Windows build, press
Ctrl+Shift+Alt+D, confirm the Develop menu appears, and confirm reload shortcuts remain blocked when debug mode is off.