Skip to content

fix: make daily check-in readonly in rewards#923

Merged
lefarcen merged 1 commit intomainfrom
fix/daily-checkin-readonly-900
Apr 8, 2026
Merged

fix: make daily check-in readonly in rewards#923
lefarcen merged 1 commit intomainfrom
fix/daily-checkin-readonly-900

Conversation

@anthhub
Copy link
Copy Markdown

@anthhub anthhub commented Apr 8, 2026

What

Make the daily check-in task render as a readonly completed item in the rewards page instead of a manual-claim action.

Why

Closes #900.

The current UI still exposes a clickable daily check-in entry, which makes the task look manually claimable and contributed to repeated-claim confusion. This change removes that interaction surface and shows the task as already handled.

How

  • Treat daily_checkin as a readonly task in the rewards page UI
  • Reuse the completed-state visual treatment and disable the CTA permanently for that task
  • Add dedicated i18n copy that explains the reward is auto-granted and needs no manual claim
  • Add a focused web regression test covering the readonly completed state and subtitle copy

Affected areas

  • Desktop app (Electron shell)
  • Controller (backend / API)
  • Web dashboard (React UI)
  • OpenClaw runtime
  • Skills
  • Shared schemas / packages
  • Build / CI / Tooling

Checklist

  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes
  • pnpm generate-types run (if API routes/schemas changed)
  • No credentials or tokens in code or logs
  • No any types introduced (use unknown with narrowing)

Notes for reviewers

This PR intentionally does not change auto-grant behavior or reward accounting. It only removes the manual claim entry point for daily_checkin and updates the UI copy to match that product behavior.

@anthhub anthhub force-pushed the fix/daily-checkin-readonly-900 branch from 69a2fbc to 8f5dddf Compare April 8, 2026 06:59
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69a2fbc8d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/pages/rewards.tsx
Comment thread apps/web/src/hooks/use-desktop-budget-guard.ts
@anthhub anthhub force-pushed the fix/daily-checkin-readonly-900 branch from 8f5dddf to d8927ea Compare April 8, 2026 07:01
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/web/src/pages/rewards.tsx 78.12% 7 Missing ⚠️
apps/web/src/i18n/locales/en.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@lefarcen lefarcen merged commit 29a4391 into main Apr 8, 2026
14 of 15 checks passed
@lefarcen lefarcen mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily check-in allows duplicate point rewards

2 participants