Skip to content

fix: clean up credits banner and rewards prompts#918

Merged
lefarcen merged 2 commits intomainfrom
fix/credits-prompts-cleanup
Apr 8, 2026
Merged

fix: clean up credits banner and rewards prompts#918
lefarcen merged 2 commits intomainfrom
fix/credits-prompts-cleanup

Conversation

@anthhub
Copy link
Copy Markdown

@anthhub anthhub commented Apr 8, 2026

What

Clean up desktop credits prompt behavior across budget banners, Rewards hints, and Chinese copy.

Why

This addresses the credits prompt regressions tracked in #905, #907, and #912.

How

  • centralize budget-banner route policy so Home stays inline, Skills pages stay hidden, and session surfaces keep their dedicated handling
  • gate the Rewards switch-back hint on BYOK + cloudBalance.totalBalance > 0
  • update zh-CN budget banner terminology from 套餐额度 to 可用积分
  • add regression coverage for route gating, Rewards hint behavior, and zh-CN copy

Affected areas

  • Desktop app (Electron shell)
  • Controller (backend / API)
  • Web dashboard (React UI)
  • OpenClaw runtime
  • Skills
  • Shared schemas / packages
  • Build / CI / Tooling

Checklist

  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes
  • pnpm generate-types run (if API routes/schemas changed)
  • No credentials or tokens in code or logs
  • No any types introduced (use unknown with narrowing)

Notes for reviewers

@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/web/src/pages/rewards.tsx 80.00% 1 Missing and 2 partials ⚠️
apps/web/src/pages/home.tsx 77.77% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@lefarcen lefarcen merged commit 34fd141 into main Apr 8, 2026
13 checks passed
@lefarcen lefarcen mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants