fix(web): move promo banner between hero and channels#757
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b01a257f8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| setShowSeedancePromo(false); | ||
| try { | ||
| localStorage.setItem(SEEDANCE_PROMO_DISMISS_KEY, "1"); | ||
| sessionStorage.setItem(SEEDANCE_PROMO_DISMISS_KEY, "1"); |
There was a problem hiding this comment.
Persist promo dismissal across browser sessions
Switching the dismiss flag from localStorage to sessionStorage means users who dismiss the Seedance promo will see it again after closing/reopening the tab or app session, which is a regression from durable dismissal behavior implied by SEEDANCE_PROMO_DISMISS_KEY and the previous implementation in apps/web/src/pages/home.tsx. If this banner is meant to stay dismissed once closed, this change will repeatedly resurface it and degrade UX.
Useful? React with 👍 / 👎.
What
Move Seedance promo banner position in the connected-channels view (Scene B) from below channels to between the hero section and the channels card.
Why
The banner should appear right after the bot status/model info area, above the channels — not buried below them.
How
Moved the
SeedancePromoBannerrender from after the channels</div>to before{/* ═══ MIDDLE: Channels panel ═══ */}.Affected areas
Checklist
pnpm typecheckpassespnpm testpassesanytypes introduced