fix: select matching mac artifacts for desktop e2e#712
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73e1721f00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lefarcen
approved these changes
Mar 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Select the desktop E2E DMG/ZIP artifacts that match the current Mac architecture, accept both nightly and local desktop dist artifact names, and make downloads atomic.
Why
The E2E flow defaulted to arm64 artifacts and then picked the first file in
e2e/desktop/artifacts, which caused Intel Macs to launch the wrong app binary and fail smoke runs withBad CPU type in executable. Interrupted downloads could also leave partial DMGs behind that looked fresh but were not mountable. After fixing arch selection, the resolver also needed to keep supporting local unsigned desktop builds copied fromapps/desktop/release/.How
arm64orx64release path*-mac-<arch>.{dmg,zip}) and local dist names (nexu-<version>-<arch>.{dmg,zip})*.partialand rename only after curl succeeds to avoid stale partial artifactsAffected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
Validated locally on Intel macOS with:
pnpm test:smokeagainst downloaded nightly x64 artifactspnpm dist:mac:unsigned:x64followed byNEXU_DESKTOP_E2E_SKIP_CODESIGN=true pnpm --dir e2e/desktop test:smokeThe local unsigned smoke run selected
nexu-0.1.7-x64.dmg/nexu-0.1.7-x64.zipand reached runtime health successfully.