fix(desktop): window close hides to background instead of showing quit dialog#673
Merged
fix(desktop): window close hides to background instead of showing quit dialog#673
Conversation
…t dialog - Red traffic light / window close → hide window, services keep running - Cmd+Q / Dock Quit → full teardown and exit (no dialog) - Removed quit dialog, i18n strings, and showQuitDialog function - Updated tests: dialog-related tests replaced with hide-to-background tests
mrcfps
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the quit dialog when closing the window. Instead, follow standard macOS behavior.
Why
Users expect clicking the red traffic light to hide the app to background (like Slack, Discord, Telegram). The quit dialog was confusing and added friction.
How
window.hide(), services keep running in backgroundteardownLaunchdServicesandapp.exit(0)showQuitDialog,getQuitDialogLocale, i18n strings,dialogimport-92 linesof dialog code,+11 linesof simpler hide logicBehavior matrix
Checklist
pnpm typecheckpassespnpm testpasses (58 files, 614 tests)🤖 Generated with Claude Code