feat(controller): use group name for group chat session titles#660
Merged
feat(controller): use group name for group chat session titles#660
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0819832d9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
added 2 commits
March 30, 2026 14:56
Slack uses G (group) and D (DM) prefixes in addition to C (channel). Without filtering these, raw IDs like G01ABC2DEF3 could appear as group chat titles instead of falling back to senderName.
This was referenced Mar 30, 2026
mrcfps
approved these changes
Mar 30, 2026
lefarcen
approved these changes
Mar 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use human-readable group names (instead of sender names) as session titles for group chats.
Why
Group chat sessions were previously titled with the first sender's name, which is confusing when multiple people participate. The group name is more descriptive and helps users identify conversations at a glance.
How
groupNamefrom conversation metadata with multi-source fallback (group_name>chat_name>group_subject>conversation_label)oc_/ou_prefixes, Slack channel IDs likeC05ABCD1234) so they don't appear as titlesgroupNameoversenderNamein the title inference logicAffected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)