Skip to content

feat: add system proxy support for desktop runtime#637

Merged
lefarcen merged 10 commits intomainfrom
feat/support-proxy
Mar 30, 2026
Merged

feat: add system proxy support for desktop runtime#637
lefarcen merged 10 commits intomainfrom
feat/support-proxy

Conversation

@mrcfps
Copy link
Copy Markdown
Contributor

@mrcfps mrcfps commented Mar 28, 2026

What

Add normalized system proxy support across the desktop runtime, controller outbound HTTP, and desktop diagnostics.

Why

Desktop users behind corporate or system proxies need Electron traffic and controller-managed outbound requests to honor proxy env configuration while keeping loopback runtime traffic direct. Closes #607.

How

  • add shared proxy normalization for HTTP_PROXY / HTTPS_PROXY / ALL_PROXY / NO_PROXY, including enforced loopback bypass entries
  • apply the normalized policy to Electron networking and propagate uppercase proxy env vars into desktop child-process manifests / launchd startup
  • route controller outbound HTTP through a shared proxy-aware fetch helper, add proxy diagnostics coverage, and document troubleshooting behavior

Affected areas

  • Desktop app (Electron shell)
  • Controller (backend / API)
  • Web dashboard (React UI)
  • OpenClaw runtime
  • Skills
  • Shared schemas / packages
  • Build / CI / Tooling

Checklist

  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes
  • pnpm generate-types run (if API routes/schemas changed)
  • No credentials or tokens in code or logs
  • No any types introduced (use unknown with narrowing)

Notes for reviewers

Please focus on proxy bypass behavior for local controller/OpenClaw traffic versus external HTTPS requests, plus launchd/env propagation in packaged mode.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8434b59029

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/controller/src/lib/proxy-fetch.ts
Comment thread apps/desktop/shared/proxy-config.ts
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5f4035a6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/desktop/main/services/plist-generator.ts Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dae244c8b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/controller/src/lib/proxy-fetch.ts Outdated
@lefarcen lefarcen merged commit b0e1a54 into main Mar 30, 2026
11 checks passed
@lefarcen lefarcen mentioned this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support system proxy settings and proxy environment variables

2 participants