apps/controller/tests/openclaw-runtime-plugin-writer.test.ts (2)

29-31: Guard teardown to avoid masking setup failures.

If Line 22 throws before assignment, Line 30 can throw during cleanup and obscure the real failure. A small guard makes the failure signal cleaner.

🛠️ Proposed hardening

-let rootDir: string;
+let rootDir: string | undefined;
@@
 afterEach(async () => {
-  await rm(rootDir, { recursive: true, force: true });
+  if (rootDir) {
+    await rm(rootDir, { recursive: true, force: true });
+    rootDir = undefined;
+  }
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/controller/tests/openclaw-runtime-plugin-writer.test.ts` around lines 29
- 31, The teardown in the afterEach block can throw if rootDir was never
assigned during setup; modify the afterEach to guard the cleanup by checking
that rootDir is defined and exists before calling rm (e.g., typeof rootDir !==
'undefined' and/or fs.existsSync(rootDir)), then await rm only when the guard
passes; update the afterEach containing rm(...) so it references rootDir and rm
safely to avoid masking setup failures.

---

23-26: Narrow the env contract instead of force-casting to ControllerEnv.

Line 23–26 uses as ControllerEnv, which hides the actual interface contract. The class only accesses runtimePluginTemplatesDir and openclawExtensionsDir, so the constructor should declare a minimal interface rather than relying on a broad type assertion.

Define a RuntimePluginWriterEnv interface in the writer, update the constructor parameter, and remove the type assertion in the test. This prevents contract drift and keeps type checks strict without deferred failures.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/controller/tests/openclaw-runtime-plugin-writer.test.ts` around lines 23
- 26, Define a narrow interface named RuntimePluginWriterEnv in the openclaw
runtime writer module that exposes only runtimePluginTemplatesDir and
openclawExtensionsDir, change the writer class constructor signature to accept
RuntimePluginWriterEnv instead of ControllerEnv (e.g., constructor(env:
RuntimePluginWriterEnv) or update the class name's constructor accordingly), and
then remove the test's force-cast "as ControllerEnv" in
apps/controller/tests/openclaw-runtime-plugin-writer.test.ts so the test object
matches the new RuntimePluginWriterEnv shape directly.