fix(controller): skip redundant config writes to break Feishu restart loop#347
Merged
alchemistklk merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
β¦ loop The config writer unconditionally wrote the config file on every syncAll() call, even when content was unchanged. This triggered OpenClaw's file watcher, causing a reload/restart cycle: restart β WS reconnect β syncAll() β write β watcher fires β restart again. Feishu channels were most affected because their WebSocket initialization is slower than other channels, so the snapshot was never ready before the next restart. Keep the last-written content in memory and skip the write when it matches, breaking the loop after the first legitimate write.
Contributor
Author
|
/cr |
|
β CR topic created in Feishu topic group Refly CR. |
mrcfps
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #377
Summary
OpenClawConfigWriter.write()unconditionally wrote the config file on everysyncAll()call, triggering OpenClaw's file watcher even when content was unchangedTest plan
π€ Generated with Claude Code