fix(desktop): kill zombie child processes on app quit#346
Merged
alchemistklk merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
The before-quit handler was fire-and-forget (void orchestrator.dispose()), so Electron exited before child processes were terminated. Additionally, stopUnit() only sent SIGTERM twice without escalating to SIGKILL, allowing processes to ignore shutdown and become orphans that block app deletion. - Await orchestrator.dispose() by blocking quit with event.preventDefault() - Escalate to SIGKILL after 3s if SIGTERM is ignored - Add 5s final deadline to prevent hanging quit
Contributor
Author
|
/cr |
|
✅ CR topic created in Feishu topic group Refly CR. |
lefarcen
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #510
Summary
orchestrator.dispose()inbefore-quit— previously fire-and-forget (void), Electron exited before child processes were killed, leaving orphans that blocked app deletion ("The application Nexu is not open anymore")stopUnit()sent SIGTERM twice (ignorable); now sends SIGTERM → waits 3s → SIGKILL → 5s final deadlineTest plan
pnpm dist:mac:unsigned)ps aux | grep Nexu)/Applications/Nexu.appfrom Finder — should succeed without "item is in use" error🤖 Generated with Claude Code