Skip to content

fix: add logout confirmation dialogs in settings#1069

Merged
Siri-Ray merged 1 commit intomainfrom
fix/logout-confirm-dialog
Apr 13, 2026
Merged

fix: add logout confirmation dialogs in settings#1069
Siri-Ray merged 1 commit intomainfrom
fix/logout-confirm-dialog

Conversation

@Siri-Ray
Copy link
Copy Markdown
Contributor

What

Add logout confirmation dialogs for the settings account action and the nexu Official provider action.

Why

Both logout entry points were disconnecting the current nexu account immediately. Adding a confirmation step reduces accidental logout/disconnects.

How

  • add a reusable logout confirmation dialog in apps/web/src/pages/models.tsx
  • show the dialog before disconnecting from General > Account
  • show the dialog before disconnecting from AI Model Providers > nexu Official
  • add matching English and Chinese copy
  • remove the dialog divider for this confirmation modal only

Affected areas

  • Desktop app (Electron shell)
  • Controller (backend / API)
  • Web dashboard (React UI)
  • OpenClaw runtime
  • Skills
  • Shared schemas / packages
  • Build / CI / Tooling

Checklist

  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes
  • pnpm generate-types run (if API routes/schemas changed)
  • No credentials or tokens in code or logs
  • No any types introduced (use unknown with narrowing)

Notes for reviewers

pnpm test was not run because this is a small UI-only change with no logic or API contract changes beyond the existing logout flow.

@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 8.23529% with 78 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/web/src/pages/models.tsx 1.36% 72 Missing ⚠️
apps/web/src/i18n/locales/en.ts 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Siri-Ray Siri-Ray merged commit 240127c into main Apr 13, 2026
14 of 15 checks passed
@lefarcen lefarcen mentioned this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants