fix: preserve dingtalk bundled plugin dependencies#1037
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
lefarcen
approved these changes
Apr 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Repair bundled runtime plugin dependency resolution so packaged builds keep
dingtalk-streamfordingtalk-connectorwithout regressingsilk-wasmforopenclaw-qqbot.Why
PR #1001 fixed qqbot by preferring a plugin package's local
node_modules, but that breaks pnpm-installed plugins likedingtalk-connectorwhose package-localnode_modulesonly contains.bin. Packaged Windows builds could then ship adingtalk-connectorplugin withoutdingtalk-stream, causingCannot find module 'dingtalk-stream'after gateway restarts.How
bundle-runtime-pluginsto prefer package-localnode_modulesonly when it contains real dependencies, otherwise fall back to the pnpm virtual-store dependency root.openclaw-qqbot/silk-wasmanddingtalk-connector/dingtalk-streammust exist.Affected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
pnpm --filter @nexu/controller exec vitest run tests/bundle-runtime-plugins.test.ts tests/openclaw-runtime-plugin-writer.test.ts.pnpm --filter @nexu/controller bundle-runtime-pluginsandpnpm --filter @nexu/desktop prepare:controller-sidecarand confirmed both packaged plugin trees now containdingtalk-streamandsilk-wasm.