Skip to content

fix(web): fix Mac sidebar toggle overlapping traffic lights#1002

Merged
lefarcen merged 1 commit intomainfrom
fix/mac-sidebar-toggle-overlap
Apr 9, 2026
Merged

fix(web): fix Mac sidebar toggle overlapping traffic lights#1002
lefarcen merged 1 commit intomainfrom
fix/mac-sidebar-toggle-overlap

Conversation

@lefarcen
Copy link
Copy Markdown
Collaborator

@lefarcen lefarcen commented Apr 9, 2026

Summary

  • Mac sidebar toggle button now stays fixed at traffic light position (top-[10px] left-[76px]) in both expanded and collapsed states, only switching between open/close icons
  • Remove duplicate toggle from header on Mac — it was causing the button to jump between two positions
  • Add navigator.userAgent fallback for platform detection when VITE_DESKTOP_PLATFORM env is not available (fixes dev mode detection)
  • Inject VITE_DESKTOP_PLATFORM into web dev server env

Test plan

  • Mac: sidebar toggle stays next to traffic lights in both states
  • Mac: logo has proper spacing below traffic light area
  • Windows: sidebar toggle behavior unchanged
  • Dev mode: platform correctly detected as darwin/win32

🤖 Generated with Claude Code

- Mac toggle button now fixed at traffic light position in both
  expanded and collapsed states
- Remove toggle from header on Mac (stays in fixed position)
- Add navigator.userAgent fallback for platform detection when
  VITE_DESKTOP_PLATFORM env is not available (dev mode)
- Inject VITE_DESKTOP_PLATFORM into web dev server env

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/web/src/layouts/workspace-layout.tsx 4.76% 20 Missing ⚠️
apps/web/src/lib/desktop-platform.ts 0.00% 11 Missing ⚠️
scripts/dev/src/shared/dev-runtime-config.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@lefarcen lefarcen merged commit 157b50c into main Apr 9, 2026
14 checks passed
@lefarcen lefarcen mentioned this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants