Allow build names to use alphanumeric characters#522
Merged
Conversation
This allows for build names like "A222V" or "501Y-V1". When experimenting with this just now I couldn't figure out why Snakemake was refusing to build until I caught this wildcard constraints issue. I imagine this would surprise others as well.
Member
|
Hm! I have a memory of looking over a PR that @huddlej did of this! Did we just forget to merge it? Apologies if so... Super strange! Anyway, we should definitely include this or the original (I imagine they are basically the same :) ) |
Collaborator
|
FWIW, the WA ncov builds have had this modification for months now and works just fine: https://github.com/blab/ncov-wa-build/blob/master/Snakefile#L78 |
huddlej
approved these changes
Dec 21, 2020
Contributor
huddlej
left a comment
There was a problem hiding this comment.
This worked for me! Merging now.
This was referenced Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for build names like
A222Vor501Y-V1. When experimenting with this just now I couldn't figure out why Snakemake was refusing to build until I caught this wildcard constraints issue. I imagine this would surprise others as well.