Merged
Conversation
The temporal grouping attribute was changed from 'week' to 'year month' inadvertently in "Use population-based weighted sampling for Asia builds" (bc3f69e). Revert it back to 'week'.
This has been superseded by the following comment on country grouping with population size weights.
The grouping information is not necessary here and became inaccurate with the switch to country-based weighted sampling. It is only necessary for other regions to distinguish `nextstrain_region_grouped_by_country_*` from `nextstrain_region_grouped_by_division_*`.
Follow-up to "Use population-based weighted sampling for Asia builds" (bc3f69e) and subsequent fixes. Those were only applied to the open and gisaid profiles, inadvertently skipping the gisaid-21L profile.
This was referenced Aug 26, 2024
trvrb
approved these changes
Sep 26, 2024
Member
trvrb
left a comment
There was a problem hiding this comment.
Looks great! Individual commits and commit messages are very clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Follow-up fixes to #1106. See commit messages.
Trial build links
GISAID/asia
GISAID 21L/asia
open (GenBank)/asia
Checklist
UpdateUpdating in Use weighted sampling for other builds #1151docs/src/reference/change_log.mdin this pull request to document these changes by the date they were added.