Remove RDB-level related rules/files#1097
Merged
joverlee521 merged 2 commits intomasterfrom Feb 1, 2024
Merged
Conversation
5 tasks
Member
jameshadfield
left a comment
There was a problem hiding this comment.
Code looks good by inspection (I haven't run the workflow to properly test).
If we want to reinstate this behaviour, or something similar, it would be useful to be able to just revert a commit. As such, how about making these changes on top of a working version (#1094)?
Prompted by #1094, which led to internal conversation¹ that determined we should just drop the RBD-levels. ¹ https://bedfordlab.slack.com/archives/CSKMU6YUC/p1706643360558109
ad2f19e to
d359784
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Prompted by #1094, which led to internal conversation¹ that determined we should just drop the RBD-levels.
¹ https://bedfordlab.slack.com/archives/CSKMU6YUC/p1706643360558109
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Release checklist
If this pull request introduces backward incompatible changes, complete the following steps for a new release of the workflow:
docs/src/reference/change_log.mdin this pull request to document these changes and the new version number.If this pull request introduces new features, complete the following steps:
docs/src/reference/change_log.mdin this pull request to document these changes by the date they were added.