Merged
Conversation
5 tasks
872bddc to
2c06854
Compare
5962ddb to
65f8fe4
Compare
1 task
2c06854 to
522fe9c
Compare
65f8fe4 to
b5cb803
Compare
522fe9c to
17ca960
Compare
62e01e5 to
5779a70
Compare
I plan to use actual values in subsequent examples. Region gets the point across in a more politically neutral way.
17ca960 to
76ff695
Compare
Probabilistic sampling is really a special case of uniform sampling, not a separate sampling method. Make it a section under caveats.
This makes it easier to add a section on weighted sampling, which also falls under grouped sampling and shares the same caveats as uniform sampling.
Add a new section and adjust existing content accordingly.
Weighted sampling makes this scenario technically feasible, but practically difficult to achieve in a single augur filter call. Explain this trade-off in detail.
f4443a5 to
c6084f3
Compare
5 tasks
genehack
approved these changes
Aug 22, 2024
This was referenced Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
Adding docs for nextstrain/augur#1318
Checklist