Skip to content

Provide nextclade2 and nextalign2 while retaining the default of v1#54

Merged
tsibley merged 1 commit intomasterfrom
add-nextclade-v2
Jun 17, 2022
Merged

Provide nextclade2 and nextalign2 while retaining the default of v1#54
tsibley merged 1 commit intomasterfrom
add-nextclade-v2

Conversation

@tsibley
Copy link
Copy Markdown
Contributor

@tsibley tsibley commented Jun 17, 2022 •
edited
Loading

Having both available will aid transitions from v1 → v2, including
ours.¹ At some point we'll switch the default to v2 but still keep v1
around.

¹ https://bedfordlab.slack.com/archives/C7SDVPBLZ/p1655488730483759?thread_ts=1655459762.164449&cid=C7SDVPBLZ

Related issue(s)

Obsoletes #43.

Testing

  • CI
  • Confirm all 4 binaries work in image

@tsibley
Provide nextclade2 and nextalign2 while retaining the default of v1
0c31ad4 
Having both available will aid transitions from v1 → v2, including
ours.¹ At some point we'll switch the default to v2 but still keep v1
around.

¹ https://bedfordlab.slack.com/archives/C7SDVPBLZ/p1655488730483759?thread_ts=1655459762.164449&cid=C7SDVPBLZ
@tsibley tsibley force-pushed the add-nextclade-v2 branch from c53fb12 to 0c31ad4 Compare June 17, 2022 21:08
@tsibley
Copy link
Copy Markdown
Contributor Author

tsibley commented Jun 17, 2022 

$ nextstrain shell --image nextstrain/base:branch-add-nextclade-v2 /var/empty
Entering the Nextstrain build environment

Mapped volumes:
  /nextstrain/build is from /var/empty

Run the command "exit" to leave the build environment.

nextstrain:/nextstrain/build $ nextalign --version && nextclade --version
1.11.0
1.11.0
nextstrain:/nextstrain/build $ nextalign1 --version && nextclade1 --version
1.11.0
1.11.0
nextstrain:/nextstrain/build $ nextalign2 --version && nextclade2 --version
nextalign 2.0.0-beta.2
nextclade 2.0.0-beta.2

@tsibley tsibley merged commit c2ea7a8 into master Jun 17, 2022
@tsibley tsibley deleted the add-nextclade-v2 branch June 17, 2022 21:25
@tsibley tsibley mentioned this pull request Jun 17, 2022
Closed
@victorlin victorlin mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tsibley