Skip to content

Dockerfile and requirements.txt#2

Merged
trvrb merged 2 commits intomasterfrom
dependencies
Sep 24, 2016
Merged

Dockerfile and requirements.txt#2
trvrb merged 2 commits intomasterfrom
dependencies

Conversation

@smur232
Copy link
Copy Markdown
Contributor

@smur232 smur232 commented Sep 24, 2016

No description provided.

@trvrb
Copy link
Copy Markdown
Member

trvrb commented Sep 24, 2016

The docker build worked just fine for me. There is one suggestion however, I see why you did RUN pip install -r requirements.txt rather than including each pip install directly in the Dockerfile. Makes total sense to have just one set of dependencies. However, thought should be spent on how to do this caching. Putting RUN pip install -r requirements.txt before the cache bust means that if requirements.txt is updated in the repo then the pip install -r requirements.txt won't rerun. While if cache bust is placed before the pip install -r requirements.txt, then there will be a lengthy install with every build.

I feel there must be a better way of managing the cache in Docker.

@trvrb trvrb merged commit 8910639 into master Sep 24, 2016
@trvrb
Copy link
Copy Markdown
Member

trvrb commented Sep 24, 2016

I'm going to merge this now. Works great. Thank you! Can look into caching more in general.

@trvrb trvrb deleted the dependencies branch September 24, 2016 06:06
@smur232
Copy link
Copy Markdown
Contributor Author

smur232 commented Sep 24, 2016

That's true!
Sounds good, I will get back to you about cacheing soon - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants