You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The docker build worked just fine for me. There is one suggestion however, I see why you did RUN pip install -r requirements.txt rather than including each pip install directly in the Dockerfile. Makes total sense to have just one set of dependencies. However, thought should be spent on how to do this caching. Putting RUN pip install -r requirements.txt before the cache bust means that if requirements.txt is updated in the repo then the pip install -r requirements.txt won't rerun. While if cache bust is placed before the pip install -r requirements.txt, then there will be a lengthy install with every build.
I feel there must be a better way of managing the cache in Docker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.