Skip to content

Allow conditions with property names in keys and in sub-array keys to be combined #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hrach merged 2 commits into from
Oct 26, 2025
Merged

Allow conditions with property names in keys and in sub-array keys to be combined #775

hrach merged 2 commits into from
Oct 26, 2025

Conversation

@mabar
Copy link
Contributor

@mabar mabar commented Oct 25, 2025 •
edited
Loading

Before

[ICollection::AND, 'id' => 1, 'name=' => 'John'] // ok
[ICollection::AND, ['id' => 1], ['name' => 'John']] // ok
[ICollection::AND, 'id' => 1, ['name=' => 'John']] // some exception about collection function

Now - all variants work

Why? We have some lengthy conditions accross multiple functions and conditions, written in the first syntax. To add a collection function to conditions, we have to rewrite them all to the second syntax. With this PR, rewriting everything is no longer necessary.

@hrach hrach merged commit a4971a5 into nextras:main Oct 26, 2025
9 checks passed
@mabar mabar deleted the mixed-array-key-value-syntax branch October 26, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mabar @hrach