Skip to content

Fix Date(time) instance in primary key #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hrach merged 2 commits into from
Oct 9, 2024
Merged

Fix Date(time) instance in primary key #677

hrach merged 2 commits into from
Oct 9, 2024

Conversation

@jkavalik
Copy link
Contributor

@jkavalik jkavalik commented Oct 8, 2024

No description provided.

@hrach
Copy link
Member

hrach commented Oct 8, 2024

Please, as you can see, since updates to other rdbms' it is best to keep changes as small as possible. Please, fix all build issues. Thx.

@jkavalik
Copy link
Contributor Author

jkavalik commented Oct 8, 2024 •
edited
Loading

Yes, working on it.
OTOH the first tests failure seems unrelated to me

Service container mysql80 failed.
Service container mssql failed.

for MySQL specifically

Error:  2024-10-08T09:40:01.976192Z 0 [ERROR] [MY-000067] [Server] unknown variable 'default-authentication-plugin=mysql_native_password'.

I will look into that too

@hrach
Copy link
Member

hrach commented Oct 8, 2024

Oh, sorry, that something that broke and I hadn't time to fix it. If you don't want, let fixing this on me.

@jkavalik jkavalik force-pushed the DatetimePK branch 8 times, most recently from fbcba0e to f987af7 Compare October 8, 2024 16:51
hrach
hrach reviewed Oct 8, 2024
View reviewed changes
tests/cases/integration/Entity/entity.compositePK.phpt Outdated
Comment on lines 79 to 80
$res = $this->orm->userStatsX->getBy(['date' => new DateTime('2019-01-01')]);
Assert::notNull($res);
Copy link
Member

@hrach hrach Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getByChecked?

@hrach
Copy link
Member

hrach commented Oct 8, 2024

Awesome <3

@jkavalik
Copy link
Contributor Author

jkavalik commented Oct 9, 2024

I replaced getBy(Id)/assertNotNull by their checked variant in the files tests I touched (except the case where it would lead to unused variable).

@hrach
Copy link
Member

hrach commented Oct 9, 2024

@jkavalik could you please fixup relevant commits, i.e. keep split fixing CI; and then your fix with tests in another commit? thx

@jkavalik
Copy link
Contributor Author

jkavalik commented Oct 9, 2024 •
edited
Loading

Reordered and squashed
Edit - and some mistake..

@jkavalik
Copy link
Contributor Author

jkavalik commented Oct 9, 2024

Fixed a bad conflict resolution..

@hrach hrach linked an issue Oct 9, 2024 that may be closed by this pull request
Problem with UPDATE on DATE primary key #676
Closed
@hrach hrach merged commit 55e164e into nextras:main Oct 9, 2024
@hrach
Copy link
Member

hrach commented Oct 9, 2024

Thank you a lot!

@hrach hrach changed the title Date(time) pk Fix Date(time) instance in primary key Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hrach hrach hrach left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem with UPDATE on DATE primary key

2 participants

@jkavalik @hrach