Fix spurious WARN when workflow fails before onFlowBegin#6816
Merged
pditommaso merged 1 commit intomasterfrom Feb 7, 2026
Merged
Fix spurious WARN when workflow fails before onFlowBegin#6816pditommaso merged 1 commit intomasterfrom
pditommaso merged 1 commit intomasterfrom
Conversation
Skip sending the /complete request to Seqera Platform when onFlowBegin was never invoked, avoiding a 403 response and confusing warning message for early workflow failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onFlowBeginis invoked (e.g., script parsing error),onFlowCompletestill sends a/completerequest to the Platform API, which gets rejected with 403 and produces a confusing WARN messageonFlowBeginwas never called, by checking that thesenderthread (only set inonFlowBegin) is non-nullTest plan
should not send complete request when onFlowBegin was not invoked./launch.sh run t.nf -with-towerwith a script that fails immediately — verify no WARN about unexpected HTTP response🤖 Generated with Claude Code