Improve error message for invalid config statements#6804
Merged
bentsherman merged 2 commits intomasterfrom Feb 6, 2026
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common pattern pre-strict syntax was to mix config statements (assignments, blocks, includes) with imperative statements (if-else, try-catch, etc)
For example:
In the v2 parser, I try to detect these patterns and provide a helpful error message:
Try-catch blocks cannot be mixed with config statements, instead of a more cryptic syntax errorHowever, the above case currently yields
Unexpected input: includeConfig. This is because the try block must be parsed as imperative code, which didn't account for usingincludeConfigas a regular function name.This PR adds
includeConfigas a valid identifier so that a better error message can be given here