Skip to content

Fix different task hash with V2 parser.#6789

Merged
bentsherman merged 5 commits intomasterfrom
6788-fix-cache-problem-v2
Feb 3, 2026
Merged

Fix different task hash with V2 parser.#6789
bentsherman merged 5 commits intomasterfrom
6788-fix-cache-problem-v2

Conversation

@jorgee
Copy link
Contributor

@jorgee jorgee commented Feb 2, 2026

close #6788

This pull request introduces a fix to the script parsing logic to ensure consistent behavior between syntax parser versions, and adds new tests to verify correct process caching when resuming with different parsers. The main focus is on improving parser coherence and validating resume functionality.

Parser logic improvement:

  • Updated getSourceText in ScriptToGroovyHelper.java to skip appending a closing brace (}) if it is the last line, maintaining consistency with the V1 parser.

Testing resume behavior across parser versions:

  • Added a new test workflow in resume-different-syntax-parser.nf that defines a simple process and workflow for validation.
  • Added a corresponding shell test in .checks to verify that the process runs and caches correctly when switching between parser versions and using resume mode.

Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@jorgee jorgee requested a review from a team as a code owner February 2, 2026 16:27
@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 63855bd
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/698227bf4e57d20009004f86

@jorgee jorgee requested a review from bentsherman February 2, 2026 16:27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman merged commit 66b7438 into master Feb 3, 2026
25 checks passed
@bentsherman bentsherman deleted the 6788-fix-cache-problem-v2 branch February 3, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache resume broken when changing syntax parser.

3 participants