Add time-based caching for K8sConfig.getClient()#6742
Merged
bentsherman merged 4 commits intomasterfrom Jan 21, 2026
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Closes #6741 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
4913396 to
7d2f4c1
Compare
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
jorgee
reviewed
Jan 21, 2026
jorgee
approved these changes
Jan 21, 2026
Contributor
jorgee
left a comment
There was a problem hiding this comment.
Changes look fine.
I just miss the version added in docs.
Co-authored-by: Jorge Ejarque <jorgee@users.noreply.github.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Memoizedwith a Guava time-based cache that expires after a configurable interval (default 50 minutes)k8s.clientRefreshIntervalto control the refresh intervalChanges
clientRefreshIntervalconfig option (default:50m)clientCachefield using GuavaCache<String, ClientConfig>getClient()to use cache withgetClient0()as the loaderCloses #6741
Test plan
clientRefreshIntervaldefault and custom values🤖 Generated with Claude Code