Add runtimeClassName to the pod options#6633
Merged
bentsherman merged 5 commits intonextflow-io:masterfrom Dec 5, 2025
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ee815c2 to
9404060
Compare
Signed-off-by: Alessandro Pilotti <apilotti@cloudbasesolutions.com>
6962959 to
535dc4c
Compare
bentsherman
requested changes
Dec 4, 2025
Member
bentsherman
left a comment
There was a problem hiding this comment.
Thanks for contributing! Just a few details to resolve
plugins/nf-k8s/src/main/nextflow/k8s/model/PodSpecBuilder.groovy
Outdated
Show resolved
Hide resolved
6758042 to
ec02890
Compare
Signed-off-by: Alessandro Pilotti <apilotti@cloudbasesolutions.com>
Signed-off-by: Alessandro Pilotti <apilotti@cloudbasesolutions.com>
ec02890 to
e754523
Compare
Member
|
@alexpilotti does the PR still work on your end after the changes from the review? |
Contributor
Author
Yes, just checked again with a fresh build, all good. Tests work as well. |
Contributor
Author
For reference, here's a apiVersion: v1
kind: Pod
metadata:
name: nf-255469281f5726df29a2fa28462202f2-a1608
namespace: nf-core
labels: {nextflow.io/processName: NFCORE_CUDATEST_CUDATEST_NVIDIASMI, nextflow.io/runName: pensive_carlsson,
nextflow.io/sessionId: uuid-5b9c1e91-9a08-4b7f-8efc-839ea2c1e377, nextflow.io/app: nextflow,
nextflow.io/taskName: NFCORE_CUDATEST_CUDATEST_NVIDIASMI}
spec:
restartPolicy: Never
containers:
- name: nf-255469281f5726df29a2fa28462202f2-a1608
image: registry.nf-core:5000/nf-core-cuda
args:
- /bin/bash
- -ue
- -c
- !!org.codehaus.groovy.runtime.GStringImpl {}
resources:
requests: {cpu: 4, memory: 16384Mi, nvidia.com/gpu: 2}
limits: {memory: 16384Mi, nvidia.com/gpu: 2}
volumeMounts:
- {name: vol-1, mountPath: /workspace}
activeDeadlineSeconds: 14400
runtimeClassName: nvidia
volumes:
- name: vol-1
persistentVolumeClaim: {claimName: nf-core-data-pvc} |
bentsherman
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6632
This PR adds
runtimeClassNameto the K8s pod options in order to support scenarios where the desired container runtime configuration is not the default one as it often happens when using NVIDIA GPUs, although it can apply to other scenarios as well (e.g., kata containers).This PR includes also the corresponding updates in the documentation.
An initial commit is also included to remove unnecessary trailing whitespaces from the files affected by this PR to avoid unrelated changes in the subsequent commits, especially when using editors configured to automatically remove such whitespaces, as it is common practice.
Here's a typical configuration file usage example:
process { executor = 'k8s' accelerator { limit = 2 type = "nvidia.com/gpu" } pod = [ runtimeClassName: 'nvidia' ] }