Upgrade from Apache Commons Lang 2.6 to Commons Lang3 3.18.0#6511
Merged
pditommaso merged 2 commits intomasterfrom Oct 28, 2025
Merged
Upgrade from Apache Commons Lang 2.6 to Commons Lang3 3.18.0#6511pditommaso merged 2 commits intomasterfrom
pditommaso merged 2 commits intomasterfrom
Conversation
This commit migrates the codebase from the legacy commons-lang library to commons-lang3. Key changes include: - Updated dependency in build.gradle files from commons-lang:2.6 to commons-lang3:3.18.0 - Updated all import statements from org.apache.commons.lang to org.apache.commons.lang3 - Replaced StringEscapeUtils.escapeJavaScript() with escapeEcmaScript() in TimelineObserver (method renamed in lang3) - Replaced StrBuilder with standard Java StringBuilder in ConfigParser (StrBuilder moved to commons-text library) All modules compile successfully with the new dependency. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
approved these changes
Oct 28, 2025
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the codebase from the legacy Apache Commons Lang 2.6 library to Commons Lang3 3.18.0.
Changes
build.gradlefiles innextflow,nf-commons, andnf-wavemodules to usecommons-lang3:3.18.0org.apache.commons.langtoorg.apache.commons.lang3across 10 filesStringEscapeUtils.escapeJavaScript()withescapeEcmaScript()inTimelineObserver(method renamed in lang3)StrBuilderwith standard JavaStringBuilderinConfigParser(StrBuilder moved to commons-text library)Files Modified
modules/nextflow/build.gradlemodules/nf-commons/build.gradleplugins/nf-wave/build.gradleTesting
make compilepassesMotivation
Upgrading from the legacy commons-lang 2.x to the actively maintained commons-lang3 3.x brings modern APIs, bug fixes, and continued support.