Fix type casting in PluginSpec for ConfigScope [ci fast]#6469
Merged
pditommaso merged 1 commit intomasterfrom Oct 10, 2025
Merged
Fix type casting in PluginSpec for ConfigScope [ci fast]#6469pditommaso merged 1 commit intomasterfrom
pditommaso merged 1 commit intomasterfrom
Conversation
Replace unsafe cast with explicit type checking and casting to ensure type safety when loading ConfigScope extension points. This prevents potential ClassCastException when loading classes that may not be ConfigScope implementations. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
referenced
this pull request
Oct 10, 2025
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
bentsherman
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves type safety in the
PluginSpecclass by replacing an unsafe cast with explicit type checking and casting when loading ConfigScope extension points.Changes
(Class<? extends ConfigScope>)on line 49 with deferred casting after type checkisAssignableFromcheck ensures the class is actually a ConfigScope implementationClassCastExceptionwhen loading classes that may not be ConfigScope implementationsFiles Changed
modules/nextflow/src/main/groovy/nextflow/plugin/spec/PluginSpec.groovy🤖 Generated with Claude Code