Merged
Conversation
- Update Gradle wrapper from 8.14 to 9.1.0 - Fix Shadow plugin compatibility by updating mainClassName to application.mainClass.get() - Fix exportClasspath task for Gradle 9.1 unsafe configuration resolution - Use provider-based lazy evaluation to avoid configuration cache issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
- Update Shadow plugin from 8.3.5 to 8.3.8 for Gradle 9.1 compatibility - Remove deprecated ext.mainClassName from packing.gradle - Fix "You can't map a property that does not exist: propertyName=mainClassName" error - Resolves GitHub Actions build failures with shadowDistTar and startShadowScripts tasks 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
…e stage] - Remove provider-based approach that still triggered eager resolution - Address review comment about cfg.files causing early resolution at configuration time - Implement minimal classpath approach that avoids Gradle 9.1 unsafe resolution errors - Add detailed comments explaining Gradle 9.1 compatibility limitations - exportClasspath now creates module-only classpath with clear warning about limitations The previous provider approach still called cfg.files within the provider block, which triggered configuration resolution at configuration time, contradicting the intended fix for Gradle 9.1 compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Fixes test execution failures with Gradle 9.1 by adding the required junit-platform-launcher dependency when using useJUnitPlatform(). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code