Fix false error with storeDir and val outputs#6408
Merged
bentsherman merged 3 commits intomasterfrom Oct 14, 2025
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
It would be good to add the test case as integration test |
Member
Author
|
TODO: update |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
jorgee
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #5785
This PR fixes a false positive error with storeDir that causes it to be overly strict with value outputs.
Currently storeDir only works with value outputs of the form
val(<name>), where<name>is defined as an input or in the script block. However, any value output should be allowed, because value outputs are always evaluated and do not depend on the storeDir or resume cache.Test case:
Currently, the two value outputs above will caused the task to not be stored. With this PR, the task is stored correctly.