Fix plugin install command by adding missing prefetch metadata call#6396
Merged
pditommaso merged 1 commit intomasterfrom Sep 10, 2025
Merged
Fix plugin install command by adding missing prefetch metadata call#6396pditommaso merged 1 commit intomasterfrom
pditommaso merged 1 commit intomasterfrom
Conversation
This commit adds a comprehensive test to verify that the prefetchMetadata() method is called correctly when pulling plugins. The test ensures that: - prefetchMetadata() is called on repositories implementing PrefetchUpdateRepository - The correct PluginSpec objects are passed to prefetchMetadata() - The method is called before individual plugin processing The test uses Spock Framework with appropriate mocking to isolate the functionality being tested while following existing test patterns in the codebase. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the broken
plugin installcommand by adding the missingprefetchMetadata()call in thepullPluginsmethod.Problem
The
plugin installcommand was broken because it wasn't callingprefetchMetadata()before processing plugins, which is required for repositories that implementPrefetchUpdateRepositoryto properly initialize their metadata.Solution
prefetchMetadata(specs)call inPluginUpdater.pullPlugins()method before processing individual pluginsChanges
prefetchMetadata(specs)call inpullPlugins()method (PluginUpdater.groovy:189)Test Coverage
The new test
should prefetch plugin metadata when pulling pluginsverifies:prefetchMetadata()is called on repositories implementingPrefetchUpdateRepositoryPluginSpecobjects are passed to the prefetch methodThis fix ensures the plugin install command works properly with all repository types, especially those requiring metadata prefetching for optimal performance.
🤖 Generated with Claude Code