Support standard environment variables for ANSI terminal output#6362
Merged
bentsherman merged 8 commits intonextflow-io:masterfrom Aug 25, 2025
Merged
Support standard environment variables for ANSI terminal output#6362bentsherman merged 8 commits intonextflow-io:masterfrom
bentsherman merged 8 commits intonextflow-io:masterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
juanesarango
approved these changes
Aug 22, 2025
juanesarango
left a comment
There was a problem hiding this comment.
Looks good to me.
Thanks for implementing this so fast.
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
c79cf11 to
88f5b09
Compare
pditommaso
requested changes
Aug 23, 2025
modules/nextflow/src/main/groovy/nextflow/cli/CliOptions.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/trace/AnsiLogObserver.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
ewels
commented
Aug 23, 2025
modules/nextflow/src/main/groovy/nextflow/trace/AnsiLogObserver.groovy
Outdated
Show resolved
Hide resolved
ewels
commented
Aug 23, 2025
modules/nextflow/src/main/groovy/nextflow/trace/AnsiLogObserver.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
7dcbb26 to
0248c08
Compare
- Replace direct System.getenv() calls with SysEnv.get() for consistency - Improve TERMINAL_WIDTH parsing error handling in AnsiLogObserver - Simplify NO_COLOR validation logic - Clean up imports and static references 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Collaborator
christopher-hakkaart
left a comment
There was a problem hiding this comment.
I found some of the description unclear. I've made some suggestions.
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io> Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
christopher-hakkaart
approved these changes
Aug 25, 2025
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
17c5ddb to
b2abcac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
NO_COLORandTERMINAL_WIDTHto control ANSI output from Nextflow.These are standard environment vars already supported by other tools. They are important for accessibility reasons.
See https://no-color.org/
Follows on from #4573