Fix false warning for map config options#6359
Merged
bentsherman merged 3 commits intomasterfrom Sep 2, 2025
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jorgee
reviewed
Aug 27, 2025
jorgee
reviewed
Aug 29, 2025
modules/nextflow/src/main/groovy/nextflow/config/ConfigValidator.groovy
Outdated
Show resolved
Hide resolved
…or.groovy Co-authored-by: Jorge Ejarque <jorgee@users.noreply.github.com> Signed-off-by: Ben Sherman <bentshermann@gmail.com>
pditommaso
reviewed
Sep 2, 2025
pditommaso
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a false warning reported by the strict config parser for config options that take a map, such as
process.resourceLimits:It has to do with how the config object is flattened. Instead, the validator should recognize it as a map property of the config option
process.resourceLimits.