Replace custom retry strategy with HxClient in RepositoryProvider#6351
Merged
pditommaso merged 4 commits intomasterfrom Sep 3, 2025
Merged
Replace custom retry strategy with HxClient in RepositoryProvider#6351pditommaso merged 4 commits intomasterfrom
pditommaso merged 4 commits intomasterfrom
Conversation
- Remove custom Failsafe-based retry implementation (~70 lines) - Replace with HxClient using HxConfig for centralized retry handling - Upgrade lib-httpx dependency from 1.0.0 to 1.2.0 for HxConfig support - Maintain backward compatibility with setRetryConfig() and isRetryable() methods - Preserve all existing functionality including HTTP redirect handling - Consolidate retry logic across Nextflow to use consistent HxClient approach 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
The custom retry implementation tests are no longer applicable since retry logic is now centralized in HxClient. The retry functionality is thoroughly tested via integration tests in all repository providers. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Depend on #6354 |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the custom Failsafe-based retry strategy in
RepositoryProviderwith the standardizedHxClientretry mechanism fromlib-seqera, consolidating retry handling across the Nextflow codebase.Key Changes
setRetryConfig()andisRetryable()method signaturesBenefits
Implementation Details
The retry logic now uses
HxConfig.builder()to configure:Test Coverage
🤖 Generated with Claude Code