Skip to content

Simplify plugin download implementation#6349

Merged
pditommaso merged 3 commits intomasterfrom
simplify-plugin-downloader
Sep 3, 2025
Merged

Simplify plugin download implementation#6349
pditommaso merged 3 commits intomasterfrom
simplify-plugin-downloader

Conversation

@pditommaso
Copy link
Member

Summary

Simplifies the plugin download mechanism by removing complex OCI authentication logic and unnecessary file operations.

Changes

  • Removed OciAwareFileDownloader: Deleted the custom OCI-aware downloader class (211 lines removed)
  • Use SimpleFileDownloader: Switched HttpPluginRepository to use the standard SimpleFileDownloader
  • Streamlined PluginUpdater: Removed unnecessary file renaming logic that was redundant
  • Simplified workflow: Plugin download process now has fewer steps and less complexity

Benefits

  • Reduced code complexity and maintenance burden
  • Eliminates potential issues with OCI token authentication
  • More reliable plugin downloads using standard HTTP mechanisms
  • Cleaner, more maintainable codebase

Test plan

  • Verify plugin downloads still work correctly
  • Test plugin installation from various sources
  • Confirm no regression in plugin management functionality

🤖 Generated with Claude Code

- Remove OciAwareFileDownloader class and use SimpleFileDownloader instead
- Remove unnecessary file renaming logic in PluginUpdater
- Streamline plugin download process by removing complex OCI authentication

This simplifies the plugin download mechanism while maintaining core functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@netlify
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 39e4842
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68b80feb3721880008e3b718

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member Author

@bentsherman have a look when you have a chance

@pditommaso pditommaso merged commit a3db0f8 into master Sep 3, 2025
21 of 22 checks passed
@pditommaso pditommaso deleted the simplify-plugin-downloader branch September 3, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants