Fix GString equality checks with String#6330
Merged
bentsherman merged 3 commits intomasterfrom Aug 21, 2025
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
f4db36e to
b12e2d2
Compare
This was
linked to
issues
Aug 6, 2025
ab74df5 to
2041fcf
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
2041fcf to
7c040c7
Compare
christopher-hakkaart
approved these changes
Aug 7, 2025
Collaborator
christopher-hakkaart
left a comment
There was a problem hiding this comment.
A couple of non-blocking suggestions. Please check meaning is retained.
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the semantics of GStrings and lazy expressions in the strict syntax.
GStrings are coerced into Strings by appending
.toString()under the hood, so that equality checks like"${'test'}" == 'test'are correct.Lazy expressions in process inputs/outputs/directives are handled more consistently. Before, only GStrings and property expressions were lazily evaluated. Now, any expression that references a variable is wrapped in a closure.