Skip to content

Fix Azure startTask command concatenation#6305

Merged
pditommaso merged 2 commits intomasterfrom
fix-azure-starttask-concatenation
Aug 14, 2025
Merged

Fix Azure startTask command concatenation#6305
pditommaso merged 2 commits intomasterfrom
fix-azure-starttask-concatenation

Conversation

@adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Jul 23, 2025 •
edited
Loading

@netlify
Copy link

netlify bot commented Jul 23, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 1083648
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/689dd6702345ac000855cd73

@adamrtalbot @claude
Fix Azure Batch startTask concatenation issue (#6300)
03b0501 
Changes semicolon (;) concatenation to logical AND (&&) operator in
startTask command joining to ensure proper command chaining behavior.
This prevents Azure Batch from ignoring commands after the first
semicolon and provides better error handling when azcopy installation
or custom start tasks fail.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot adamrtalbot force-pushed the fix-azure-starttask-concatenation branch from 6c72493 to 03b0501 Compare July 23, 2025 16:55
@bentsherman bentsherman self-requested a review July 23, 2025 16:55
@bentsherman bentsherman linked an issue Jul 23, 2025 that may be closed by this pull request
nf-azure startTask concatenation fails silently #6300
Closed
@adamrtalbot adamrtalbot mentioned this pull request Jul 24, 2025
Closed
@pditommaso
Copy link
Member

pditommaso commented Jul 24, 2025

Not sure to understand what's this is solving (actually tests are broken)

@bentsherman
Copy link
Member

bentsherman commented Jul 24, 2025

I also don't understand how changing to && fixes the problem reported in the issue

@pditommaso The CI failure is happening across all PRs, looks like a quota issue:

Launching `./test-complexpaths.nf` [maniac_sax] DSL2 - revision: 71e6f6d34a
ERROR ~ Error executing process > 'foo'

Caused by:
  Status code 409, "{
    "odata.metadata":"https://nfbatchtest.westeurope.batch.azure.com/$metadata#Microsoft.Azure.Batch.Protocol.Entities.Container.errors/@Element","code":"ActiveJobAndScheduleQuotaReached","message":{
      "lang":"en-US","value":"Active job and job schedule quota for the account has been reached.\nRequestId:3a4b330c-eafc-4fbc-af7f-a7aa54415c64\nTime:2025-07-23T17:10:56.4462633Z"
    }
  }"

@pditommaso
Copy link
Member

pditommaso commented Jul 24, 2025

Looking into that

@pditommaso pditommaso merged commit 81d5c0d into master Aug 14, 2025
22 checks passed
@pditommaso pditommaso deleted the fix-azure-starttask-concatenation branch August 14, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentsherman bentsherman Awaiting requested review from bentsherman

Assignees

No one assigned

Labels

executor/azure-batch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nf-azure startTask concatenation fails silently

3 participants

@adamrtalbot @pditommaso @bentsherman