Fix AWS transfer manager anonymous fallback#6296
Merged
pditommaso merged 4 commits intomasterfrom Jul 24, 2025
Merged
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Member
|
Testing again |
pditommaso
reviewed
Jul 22, 2025
bentsherman
approved these changes
Jul 23, 2025
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
pditommaso
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6295
The CrtAsyncClient produces a NPE when receiving AnonymousCredentials from a provider (aws/aws-sdk-java-v2#5810) This is what produces failures when downloading with the S3 Transfer Manager and credentials are not set. The only working way to use anonymous credentials in the AWS S3 CRT client is is passing an AnonymousCredentialsProvider.
This PR implements a workaround to fix the fallback to anonymous credentials when no credentials are provided.
When using anynimous credentials, it is normal that the fetch for the caller account also fails. I have also changed the log message to print just the message instead of the full stack trace.