Workflow onComplete and onError sections#6275
Merged
bentsherman merged 4 commits intomasterfrom Aug 6, 2025
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
56f1d5a to
51e33e5
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
51e33e5 to
d532bb1
Compare
Collaborator
christopher-hakkaart
left a comment
There was a problem hiding this comment.
Added some suggestions for the docs.
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io> Signed-off-by: Ben Sherman <bentshermann@gmail.com>
christopher-hakkaart
approved these changes
Aug 5, 2025
Collaborator
christopher-hakkaart
left a comment
There was a problem hiding this comment.
One minor suggestion for a missing word. Otherwise looks great. Non-blocking so approved.
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io> Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new syntax for workflow onComplete and onError as sections in the entry workflow instead of closure calls.
It also deprecates config workflow handlers, as this kind of code should be implemented in a plugin trace observer. This is better anyway since a plugin is easier to re-use across multiple pipelines.