Fix silent failure when downloading a directory with AWS SDK v2#6266
Merged
pditommaso merged 2 commits intomasterfrom Jul 14, 2025
Merged
Fix silent failure when downloading a directory with AWS SDK v2#6266pditommaso merged 2 commits intomasterfrom
pditommaso merged 2 commits intomasterfrom
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting the nf-build-plugin, I have noted the download directory method implemented in the nf-amazon plugin is not checking if there are failed transfers. It could silently ignore failures in the transfers generated by the download directory in the S3 Transfer Manager. This check is already done when uploading a directory.
In this PR, the same mechanism is added for the download case. The CompleatedDirectoryDownload.failedTransfers() is inspected to check if there have been errors in the generated transfers.