Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
562508e to
913fbc1
Compare
Member
|
Well done, but looks like many tests are failing |
dd7eb37 to
576cfd7
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
576cfd7 to
f5d041e
Compare
Member
Author
|
I'm surprised the Groovy type checker didn't catch that, whatever. Tests are passing 👍 |
This was referenced Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the Nextflow tracing and observer system, primarily focused on refactoring the observer classes to support a new
TraceObserverV2interface. It also includes code cleanup, optimizations, and enhancements to improve maintainability and functionality.Refactoring and Interface Updates:
AnsiLogObserver,GraphObserver, andReportObserverto implement the newTraceObserverV2interface. This involved renaming methods (e.g.,onProcessSubmittoonTaskSubmit) and updating method parameters to use theTaskEventclass. ([[1]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-483299acf7148ae9c19ae3276b024336bfa608f5d8f5352758a68e779fee4b7fL41-R42),[[2]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-32f9369643f5607fedb8abadeef4add6bafe8b03cf753924f44056cb27cc5b71L34-R40),[[3]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f3013c28d519427f2bc730293ecb6a16a8ba9ab6f81f6151edb8437142effa36L41-R40),[[4]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f3013c28d519427f2bc730293ecb6a16a8ba9ab6f81f6151edb8437142effa36L150-R195))DefaultObserverFactoryto create instances ofTraceObserverV2implementations and introduced support for additional configuration options likeoverwritefor file-based observers. ([modules/nextflow/src/main/groovy/nextflow/trace/DefaultObserverFactory.groovyR1-R101](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f9b14e11087969ea12e554daa956fc203222087d3266b51e65c3a0635396518eR1-R101))Code Cleanup and Optimization:
GraphObserverandReportObserverthat were no longer necessary after the refactor. ([[1]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-32f9369643f5607fedb8abadeef4add6bafe8b03cf753924f44056cb27cc5b71L111-L136),[[2]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f3013c28d519427f2bc730293ecb6a16a8ba9ab6f81f6151edb8437142effa36L150-R195))finalwhere possible for better immutability and thread safety. ([[1]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-483299acf7148ae9c19ae3276b024336bfa608f5d8f5352758a68e779fee4b7fL196-R197),[[2]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-483299acf7148ae9c19ae3276b024336bfa608f5d8f5352758a68e779fee4b7fL250-R251),[[3]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f3013c28d519427f2bc730293ecb6a16a8ba9ab6f81f6151edb8437142effa36L275-R258),[[4]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f3013c28d519427f2bc730293ecb6a16a8ba9ab6f81f6151edb8437142effa36L296-R272))Functional Enhancements:
createObserversV1andcreateObserversV2methods in theSessionclass to better organize observer initialization and ensure proper metrics enablement. ([[1]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-bee88a999f8eecd3cec5fcad24b76736162be86626f89d746932f64928f24374L442-R443),[[2]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-bee88a999f8eecd3cec5fcad24b76736162be86626f89d746932f64928f24374L466-R482))ReportObserverandGraphObserverby introducing helper methods for path resolution and ensuring directory creation. ([[1]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f3013c28d519427f2bc730293ecb6a16a8ba9ab6f81f6151edb8437142effa36L275-R258),[[2]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-32f9369643f5607fedb8abadeef4add6bafe8b03cf753924f44056cb27cc5b71L55-R63))Miscellaneous:
TaskEventclass and removed unused imports. ([[1]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-483299acf7148ae9c19ae3276b024336bfa608f5d8f5352758a68e779fee4b7fL24-R29),[[2]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-f3013c28d519427f2bc730293ecb6a16a8ba9ab6f81f6151edb8437142effa36L28-R30),[[3]](https://github.com/nextflow-io/nextflow/pull/6257/files#diff-32f9369643f5607fedb8abadeef4add6bafe8b03cf753924f44056cb27cc5b71L19))These changes collectively modernize the tracing system, improve code quality, and lay the groundwork for future enhancements.