Draft
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
|
Worth following this discussion, it looks like there are not negligile perf issue with Groovy 5 and invoke dynamic apache/grails-core#15293 |
Member
Author
|
Interesting, it looks similar to the issues they had with Groovy 4. It looks like one commenter avoided the perf issues by using |
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
commented
Jan 6, 2026
bentsherman
commented
Jan 6, 2026
modules/nextflow/src/main/groovy/nextflow/extension/DumpOp.groovy
Outdated
Show resolved
Hide resolved
2 tasks
5ef5502 to
d74933b
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Member
Author
|
Found sensible workarounds to all of the compile errors Now the problem is failing tests There seems to be an issue with Path semantics:
I know that we modified Path behavior with some Groovy magic, so likely something is broken with that |
d9fa5cd to
d752bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt to upgrade to Groovy 5.
Benefits:
zip(can be added to Nextflow standard library)instanceof(can be added to Nextflow language)_for placeholder variables (can be added to Nextflow language)Changes:
Had to remove generic type arguments from
instanceofchecks as the Groovy parser doesn't allow it anymoreHad to add
@Slf4jto some inner classes to makelogwork in that class. not sure if this is a bug or just a breaking changeCurrent issues:
Groovy complained about a few implementers of
CacheFunnel, even though I didn't see anything wrong. Converting CacheFunnel to Java fixed the issue for one but not the otherMultiple issues with the type checker that I'm pretty sure are just Groovy bugs, particularly
CmdLogandDumpOpThe type checker does not recognize
targetinTaskConfigas a Map, seems like a bug. I wonder if it's an edge case sincetargetis defined in super class as private and a DelegateOverall it looks like Groovy 5 beta still has a few compiler bugs to sort out. But I'm excited to get it working so that I can bring the new pattern matching features into the Nextflow language.