Merged
Conversation
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Member
Author
|
Tagging @swingingsimian for visibility |
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Member
Author
|
Documentation for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new exception,
HttpResponseLengthExceedException, to enforce a maximum allowed HTTP response size in theRepositoryProviderclass. It also enhances theSysEnvutility to support retrieving integer and long environment variables, and adds comprehensive unit tests for these changes.New Exception Handling for HTTP Response Size:
HttpResponseLengthExceedExceptionto handle cases where an HTTP response exceeds a configurable maximum size. (modules/nextflow/src/main/groovy/nextflow/exception/HttpResponseLengthExceedException.groovy)RepositoryProvider:checkMaxLengthmethod inRepositoryProviderto validate theContent-Lengthheader of HTTP responses against the environment variableNXF_GIT_RESPONSE_MAX_LENGTH. (modules/nextflow/src/main/groovy/nextflow/scm/RepositoryProvider.groovy) [1] [2]modules/nextflow/src/main/groovy/nextflow/scm/RepositoryProvider.groovy)Enhancements to
SysEnvUtility:getIntegerandgetLongmethods to retrieve integer and long values from environment variables with optional default values. (modules/nf-commons/src/main/nextflow/SysEnv.groovy)Unit Tests:
checkMaxLength: Added unit tests to validate the behavior ofcheckMaxLengthunder various scenarios, including when the maximum length is disabled, not set, or exceeded. (modules/nextflow/src/test/groovy/nextflow/scm/RepositoryProviderTest.groovy)SysEnvEnhancements: Added unit tests for the newgetIntegerandgetLongmethods to ensure correct parsing of environment variables. (modules/nf-commons/src/test/nextflow/SysEnvTest.groovy)