Identify default git branch when downloading pipelines (#3593)#5375
Merged
pditommaso merged 3 commits intomasterfrom Oct 9, 2024
Merged
Identify default git branch when downloading pipelines (#3593)#5375pditommaso merged 3 commits intomasterfrom
pditommaso merged 3 commits intomasterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
90ba9ef to
1dc1add
Compare
pditommaso
reviewed
Oct 7, 2024
modules/nextflow/src/test/groovy/nextflow/cli/CmdInfoTest.groovy
Outdated
Show resolved
Hide resolved
pditommaso
requested changes
Oct 7, 2024
Member
pditommaso
left a comment
There was a problem hiding this comment.
Let's add a test checking an ad-hoc test repo using a non-default branch
1dc1add to
9133992
Compare
pditommaso
requested changes
Oct 8, 2024
modules/nextflow/src/main/groovy/nextflow/scm/AssetManager.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Tom Sellman <tom.sellman@seqera.io>
9133992 to
1227f8e
Compare
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Member
|
Could not resist to make this change 6795ca9. @tom-seqera would make sense to add a unit test for |
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the symbolic ref approach described here https://stackoverflow.com/a/44750379 to identify the default branch when downloading a pipeline repository.
jgit doesn't automatically create the symbolic ref, but does checkout the remote's default branch. This change creates the symbolic ref after cloning, and uses it when determining the default branch. This change does not attempt to retroactively create the symbolic ref on already downloaded local repos.
If the manifest specifices a
defaultBranch, then that will override the symbolic ref. If neitherdefaultBranchnor symbolic ref is present,masterwill be used as a fallback.