[Improvement] Extended glob#2551
Closed
Lehmann-Fabian wants to merge 3 commits intonextflow-io:fix-non-glob-escapefrom
Closed
[Improvement] Extended glob#2551Lehmann-Fabian wants to merge 3 commits intonextflow-io:fix-non-glob-escapefrom
Lehmann-Fabian wants to merge 3 commits intonextflow-io:fix-non-glob-escapefrom
Conversation
Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
Closed
Contributor
Author
|
The test failure seems not to be related to the changes we made. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the logic of #2182 into #2379
With this PR, Nextflow behaves similarly using
-process.scratch trueand not. Moreover, it reduces the number of files copied/moved if the output path contains**and the glob parameter is now correctly validated.Still, all other parameters defined here: https://www.nextflow.io/docs/latest/process.html?highlight=stage#output-path are interpreted as default values. This may still copy/move more files than necessary but could not break functionality. This could be addressed in a following contributions.