Tests for unstage strategy and fix for special characters#2181
Closed
Lehmann-Fabian wants to merge 4 commits intonextflow-io:masterfrom
Closed
Tests for unstage strategy and fix for special characters#2181Lehmann-Fabian wants to merge 4 commits intonextflow-io:masterfrom
Lehmann-Fabian wants to merge 4 commits intonextflow-io:masterfrom
Conversation
Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
…proposed in PR nextflow-io#2035. Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
Signed-off-by: Lehmann-Fabian <fabian.lehmann@informatik.hu-berlin.de>
This was referenced Jun 23, 2021
Closed
30b2ef4 to
cc77472
Compare
6564123 to
c78965b
Compare
acb53ee to
2c6665e
Compare
2c461f8 to
23432f3
Compare
e2b4a93 to
f32ea0b
Compare
cefb067 to
e523afd
Compare
0d59b4c to
b93634e
Compare
81f7cb7 to
8a43489
Compare
5a93547 to
27345a6
Compare
b4b321e to
069653d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I promised in my PR #2035, I copied my tests into a new branch and adjusted them to the new logic. I also fixed problems with special characters. So now only tests with
**fail, as expected.I saw that @pditommaso did not deleted tests for the deprecated SimpleFileCopyStrategy.stageOutCommand method. These tests are outdated and partially wrong. Should I remove them and the method as well?
I plan to create a new branch and PR implementing my solution for the extended glob. How do you think about that? Having a second branch enables others to start from this point?