Skip to content

fix(NcAppSidebarTab): Reduce pill height#8547

Merged
nfebe merged 1 commit into
mainfrom
fix/tabs-pill-height
May 18, 2026
Merged

fix(NcAppSidebarTab): Reduce pill height#8547
nfebe merged 1 commit into
mainfrom
fix/tabs-pill-height

Conversation

@kra-mo

@kra-mo kra-mo commented May 18, 2026

Copy link
Copy Markdown
Member

Follow-up to #8447

6px may have been a bit too much πŸ˜…

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

6px may have been a bit too much πŸ˜…

Signed-off-by: Laura Kramolis <git@kramo.page>
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 54.60%. Comparing base (d73eeaf) to head (a1261bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8547   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         106      106           
  Lines        3443     3443           
  Branches     1005     1005           
=======================================
  Hits         1880     1880           
  Misses       1322     1322           
  Partials      241      241           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kra-mo kra-mo requested review from ShGKme, nfebe and susnux May 18, 2026 14:43
@ShGKme ShGKme added bug Something isn't working design Design, UX, interface and interaction design labels May 18, 2026
@ShGKme ShGKme added this to the 9.8.1 milestone May 18, 2026
@ShGKme

ShGKme commented May 18, 2026

Copy link
Copy Markdown
Contributor

/backport to stable8

@nfebe nfebe merged commit 26d6db4 into main May 18, 2026
27 checks passed
@nfebe nfebe deleted the fix/tabs-pill-height branch May 18, 2026 15:09
@backportbot

backportbot Bot commented May 18, 2026

Copy link
Copy Markdown

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/8547/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a1261bbb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8547/stable8

Error: Failed to check for changes with origin/stable8: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-request bug Something isn't working design Design, UX, interface and interaction design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants