Skip to content

[stable8] feat: change NcAppNavigationItem/NcListItem active state design and NcAppContent edge style on Nextcloud 34+#8498

Merged
nfebe merged 1 commit into
stable8from
backport/8448/stable8
May 7, 2026
Merged

[stable8] feat: change NcAppNavigationItem/NcListItem active state design and NcAppContent edge style on Nextcloud 34+#8498
nfebe merged 1 commit into
stable8from
backport/8448/stable8

Conversation

@nfebe

@nfebe nfebe commented May 4, 2026

Copy link
Copy Markdown
Contributor

Main content now has a subtle left divider and rounded left edge next to the navigation. Selected nav and list items use a softly tinted pill instead of a solid primary fill.

Backport of #8448.

Before After
nc-content-and-nav-before-7222 nc-content-and-nav-before-after png

Screencast

Screencast.From.2026-04-24.20-31-16.webm

@nfebe nfebe force-pushed the backport/8448/stable8 branch from d690729 to 799af48 Compare May 4, 2026 17:14
@nfebe nfebe changed the title [stable8] feat(app-content): Revise sidebar selection and content edge styling [stable8] feat: change NcAppNavigationItem/NcListItem active state design and NcAppContent edge style on Nextcloud 34+ May 4, 2026
@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.85%. Comparing base (a3a1c1d) to head (ba4e12b).

Files with missing lines Patch % Lines
...onents/NcAppNavigationItem/NcAppNavigationItem.vue 0.00% 2 Missing ⚠️
...nents/NcAppNavigationItem/NcInputConfirmCancel.vue 0.00% 2 Missing ⚠️
src/components/NcContent/NcContent.vue 66.66% 2 Missing ⚠️
...pNavigationItem/NcAppNavigationIconCollapsible.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #8498      +/-   ##
===========================================
+ Coverage    46.84%   46.85%   +0.01%     
===========================================
  Files          195      195              
  Lines         4921     4924       +3     
  Branches      1205     1204       -1     
===========================================
+ Hits          2305     2307       +2     
- Misses        2530     2531       +1     
  Partials        86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfebe nfebe force-pushed the backport/8448/stable8 branch from 799af48 to d47e9d9 Compare May 4, 2026 17:56
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels May 4, 2026
@susnux susnux added this to the 8.39.0 milestone May 4, 2026
@susnux

susnux commented May 4, 2026

Copy link
Copy Markdown
Contributor

Cypress related (snapshots need to be updated locally (or downloaded from failed CI and committed))

Main content now has a subtle left divider and rounded left edge next
to the navigation. Selected nav and list items use a softly tinted
pill instead of a solid primary fill.

Backport of #8448 to stable8.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the backport/8448/stable8 branch from d47e9d9 to ba4e12b Compare May 5, 2026 14:31
@susnux susnux requested review from kra-mo and susnux May 5, 2026 14:52
@nfebe nfebe requested a review from ShGKme May 7, 2026 08:18
@nfebe nfebe merged commit d1b695a into stable8 May 7, 2026
19 checks passed
@nfebe nfebe deleted the backport/8448/stable8 branch May 7, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: app-navigation Related to the app-navigation component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants