feat(NcRichContenteditable): allow to pass menuContainer as string#8417
Merged
Conversation
- change default value to null (as per upstream) - allow to pass string selector as a prop - resolve selector at mounted() -> initializeTribute() Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- it's a patch for new Tribute() and should be coupled with it - upstream fix is released but not published on npm Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8417 +/- ##
==========================================
- Coverage 54.09% 54.08% -0.01%
==========================================
Files 104 104
Lines 3398 3400 +2
Branches 989 992 +3
==========================================
+ Hits 1838 1839 +1
- Misses 1321 1322 +1
Partials 239 239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
approved these changes
Apr 13, 2026
Contributor
We have quite many problems with it. At this point, I'd consider making our own solution. |
DorraJaouad
approved these changes
Apr 15, 2026
Contributor
Author
|
/backport to stable8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
mounted()->initializeTribute()initializeTribute()🚧 Tasks
Can we fork tributejs and release under@nextcloud-libraries?🏁 Checklist
stable8for maintained Vue 2 version or not applicable